CTL - Motor Controller Calculators #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomLonergan03
requested changes
Feb 13, 2025
There was a problem hiding this comment.
if you're doing the same approach i did with motors way back (and you defo don't need to, consider other options whether you go with them or not), you'll need all the frequency calculators to share a trait.
probably something like:
pub trait FrequencyCalculator {
pub fn calculate_frequency(velocity: f32) -> u8;
}this does mean some of the calculators have to take a irrelevant parameter but for test classes idm that too much
TomLonergan03
approved these changes
Feb 17, 2025
davidbeechey
approved these changes
Feb 17, 2025
davidbeechey
deleted the
hype-122-motor-controller-frequency-calculators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.