CTL - Updated Levitation Control #77
Draft
+181
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpfbastos
changed the title
jpfbastos
requested changes
Feb 9, 2025
|
Cool - we'll show lev this next week to see what they think |
davidbeechey
reviewed
Feb 9, 2025
davidbeechey
requested changes
Feb 10, 2025
davidbeechey
approved these changes
Feb 24, 2025
lib/control/src/pid_controller.rs
Outdated
| @@ -0,0 +1,133 @@ | |||
| use core::f32; | |||
There was a problem hiding this comment.
JP here - Basically it was there because we use f32::NAN for initialising the pre_error. I thought the normal version was using standard library, so I was using the core version. However, both the core and std versions are deprecated, and they're being just stored in the f32 primitive, so it can be scrapped and we can use f32::NAN by itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep as Draft PR until more info from Levitation