Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLC - CAN IO implementation #63

Merged
merged 23 commits into from
Feb 20, 2025
Merged

MLC - CAN IO implementation #63

merged 23 commits into from
Feb 20, 2025

Conversation

jpfbastos
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Jan 23, 2025

HYPE-77 CAN IO implementation

@jpfbastos jpfbastos marked this pull request as ready for review January 23, 2025 19:30
davidbeechey
davidbeechey requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@davidbeechey davidbeechey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, nearly there just a few things here and there to be fixed/added

TomLonergan03
TomLonergan03 requested changes Jan 30, 2025
View reviewed changes
@davidbeechey
Copy link
Collaborator

@jpfbastos this is looking good, but I'd like to test it in the lab before we merge it. Since we need it to move on with IMD, BMS, CanOpen, etc. could you open a new PR just with the HypedCan trait (leaving out hyped_can_derive)? That way we can get started without needing a completed+tested CAN hardware implementation. Thanks!

@jpfbastos
Copy link
Contributor Author

@jpfbastos this is looking good, but I'd like to test it in the lab before we merge it. Since we need it to move on with IMD, BMS, CanOpen, etc. could you open a new PR just with the HypedCan trait (leaving out hyped_can_derive)? That way we can get started without needing a completed+tested CAN hardware implementation. Thanks!

Done - can be found in the "Can IO simple" PR, lmk if there's anything else I need to do!

@davidbeechey davidbeechey added the needs testing Needs testing in the lab before merging label Feb 7, 2025
TomLonergan03
TomLonergan03 approved these changes Feb 14, 2025
View reviewed changes
@davidbeechey davidbeechey removed the needs testing Needs testing in the lab before merging label Feb 19, 2025
@davidbeechey
Copy link
Collaborator

davidbeechey commented Feb 20, 2025 •
edited
Loading

Tested in the lab 19/02/25-20/02/25 using the can_io_recv_test and can_io_send_test binaries :) All working

@davidbeechey davidbeechey merged commit 100fad5 into main Feb 20, 2025
14 of 15 checks passed
@davidbeechey davidbeechey deleted the hype-77-can-io-implementation branch February 20, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbeechey davidbeechey davidbeechey approved these changes

@TomLonergan03 TomLonergan03 TomLonergan03 approved these changes

@H-Allen H-Allen Awaiting requested review from H-Allen H-Allen is a code owner

Assignees

@jpfbastos jpfbastos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpfbastos @davidbeechey @TomLonergan03