Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLC - CanOpen #50

Merged
merged 9 commits into from
Feb 15, 2025
Merged

MLC - CanOpen #50

merged 9 commits into from
Feb 15, 2025

Conversation

jpfbastos
Copy link
Contributor

No description provided.

@linear Linear
Copy link

linear bot commented Nov 16, 2024

HYPE-73 CANOpen Implementation

@jpfbastos jpfbastos marked this pull request as ready for review February 9, 2025 12:21
@davidbeechey davidbeechey added the needs reviews Needs reviews, otherwise finished label Feb 9, 2025
davidbeechey
davidbeechey requested changes Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@davidbeechey davidbeechey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Have made a few comments, but apart from that some good Rust doc comments would be great.

I'm tempted to say we should split this into CanOpen and motor controller stuff - let me know what you think :)

@jpfbastos
Copy link
Contributor Author

Looking good! Have made a few comments, but apart from that some good Rust doc comments would be great.

I'm tempted to say we should split this into CanOpen and motor controller stuff - let me know what you think :)

yeah fair enough - i kinda wung it, and then forgot to a) add RustDoc comments and b) split the PRs

davidbeechey
davidbeechey approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@davidbeechey davidbeechey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

TomLonergan03
TomLonergan03 requested changes Feb 14, 2025
View reviewed changes
@davidbeechey davidbeechey merged commit 386b058 into main Feb 15, 2025
15 checks passed
@davidbeechey davidbeechey deleted the hype-73-canopen-implementation branch February 15, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbeechey davidbeechey davidbeechey approved these changes

@TomLonergan03 TomLonergan03 TomLonergan03 approved these changes

Assignees

@jpfbastos jpfbastos

Labels
needs reviews Needs reviews, otherwise finished
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpfbastos @davidbeechey @TomLonergan03