Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNS - Optical Flow Sensor (HYPE-33) #48

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

SNS - Optical Flow Sensor (HYPE-33) #48

wants to merge 24 commits into from

Conversation

ishmis
Copy link

@ishmis ishmis commented Nov 16, 2024

This implements the exact logic defined in:
https://github.com/pimoroni/pmw3901-python/blob/main/pmw3901/__init__.py

WIP

Also closes HYPE-57.

@ishmis ishmis requested a review from davidbeechey as a code owner November 16, 2024 12:56
@ishmis ishmis changed the title SNS: Optical Flow Sensor SNS: Optical Flow Sensor (HYPE-33) Nov 16, 2024
Copy link

linear bot commented Nov 16, 2024

@davidbeechey davidbeechey changed the title SNS: Optical Flow Sensor (HYPE-33) SNS - Optical Flow Sensor (HYPE-33) Nov 16, 2024
Copy link

linear bot commented Nov 16, 2024

HYPE-57 Hardware SPI

@davidbeechey davidbeechey marked this pull request as draft November 20, 2024 10:16
@davidbeechey davidbeechey mentioned this pull request Nov 26, 2024
Copy link
Author

@ishmis ishmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. @prakhars0206 iirc, the optical flow sensor was not soldered properly, can you confirm if that has been fixed?

Ideally you want to get to to the stage of testing the code asap with the actual sensor.

Copy link
Author

@ishmis ishmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has this been tested with the sensor yet?

@davidbeechey
Copy link
Collaborator

davidbeechey commented Feb 11, 2025

Things to try next:

  • 400 kHz SPI frequency
  • make sure there is a sleep between power up and secret sauce
  • setting rotation
  • using transfer not transfer in place?

@davidbeechey davidbeechey marked this pull request as ready for review February 20, 2025 15:35
@davidbeechey
Copy link
Collaborator

Tested and working 20/20/25 :)

Main problem I think was the CS line not being used. We had additional logic errors and MSB/LSB mixup which were resolved.

Supports:

  • get_motion
  • set_orientation
  • set_rotation

@davidbeechey davidbeechey requested review from TomLonergan03 and removed request for licornes-fluos February 20, 2025 15:43
@davidbeechey davidbeechey self-assigned this Feb 21, 2025
Copy link
Contributor

@TomLonergan03 TomLonergan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doubling the number of comments lmao

@davidbeechey davidbeechey added the needs reviews Needs reviews, otherwise finished label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviews Needs reviews, otherwise finished
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants