Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra - Testing #114

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Infra - Testing #114

wants to merge 16 commits into from

Conversation

TomLonergan03
Copy link
Contributor

@TomLonergan03 TomLonergan03 commented May 2, 2024 •
edited
Loading

Tests for random things:

  • Proper dummy implementations for:
    • Adc
    • Can not gonna do cos no CAN on Pis
    • Gpio already exists
    • I2c
    • Spi
    • Uart
    • MQTT
  • Mqtt logger tests
  • Keyence tests
  • other things if i feel like it

@TomLonergan03 TomLonergan03 changed the title SNS - Software testing Infra - Testing May 9, 2024
@TomLonergan03 TomLonergan03 requested a review from DylanCavers as a code owner May 9, 2024 12:59
DylanCavers
DylanCavers reviewed May 12, 2024
View reviewed changes
Copy link
Contributor

@DylanCavers DylanCavers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to mqtt stuff lgtm, will give it a proper look over and approve once the other dummy implementations are in there

davidbeechey
davidbeechey approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@davidbeechey davidbeechey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanCavers DylanCavers DylanCavers left review comments

@davidbeechey davidbeechey davidbeechey approved these changes

@licornes-fluos licornes-fluos Awaiting requested review from licornes-fluos licornes-fluos is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomLonergan03 @davidbeechey @DylanCavers