-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: OPTIC-1542: remove a buch of stale feature flags #6954
Open
luarmr
wants to merge
3
commits into
develop
Choose a base branch
from
fb-optic-1542/remove-a-buch-of-stale-feature-flags-2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: OPTIC-1542: remove a buch of stale feature flags #6954
luarmr
wants to merge
3
commits into
develop
from
fb-optic-1542/remove-a-buch-of-stale-feature-flags-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_3617_taxonomy_memory_leaks_fix
…3666_max_usages_on_region_creation_171122_short
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6954 +/- ##
========================================
Coverage 76.91% 76.91%
========================================
Files 175 175
Lines 14162 14162
========================================
Hits 10893 10893
Misses 3269 3269
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luarmr
force-pushed
the
fb-optic-1542/remove-a-buch-of-stale-feature-flags-2
branch
from
January 23, 2025 22:35
965e95f
to
6e6afe6
Compare
luarmr
changed the title
Fb optic 1542/remove a buch of stale feature flags 2
refactor: optic-1542: remove a buch of stale feature flags
Jan 23, 2025
luarmr
changed the title
refactor: optic-1542: remove a buch of stale feature flags
refactor: OPTIC-1542: remove a buch of stale feature flags
Jan 23, 2025
hlomzik
approved these changes
Jan 24, 2025
NEED WORK ON LSE |
Gondragos
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing two feature flags that have long been stale.
fflag_fix_front_dev_3666_max_usages_on_region_creation_171122_short: True,
fflag_fix_front_dev_3617_taxonomy_memory_leaks_fix: True,
No LSE code related.
You know the drill, review commit by commit.