-
Notifications
You must be signed in to change notification settings - Fork 168
WIP: Add docker-compose.yml and fix nginx paths for resources (Issue #211) #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
An unfortunate complication is that Hubs in some places refers to |
Exairnous
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the issue with building the Docker image is because of us moving away from using /docs/. This was introduced with #203 but no one thought about updating the Docker image or its nginx configuration. So I think that rather than adding more redirects for /docs/ we should be removing them. Actually, it looks like modifying the initial redirect to the following should make everything work again (and no other redirects should be needed):
location / {
root /var/www/docs;
autoindex off;
add_header 'Access-Control-Allow-Origin' '*';
}
@DougReeder Does the above seem plausible to you and in line with your changes?
| hubs-docs: | ||
| build: . | ||
| ports: | ||
| - "8080:8080" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider whethere exposing the server on port 80 would make sense.
That's cleaner. I think it should be |
|
Using |
What?
Allows a user to locally build and run a docker container hosting the documentation webserver
Why?
Makes it easy to build and run the documentation server locally without making host OS changes
Examples
How to test
docker compose builddocker compose upThen browse to localhost:8080/docs
NOTE I don't know if these changes break the CI deployment to the official server
Documentation of functionality
N/A
Limitations
Might impact CI deployment
Alternatives considered
Open questions
Does this impact CI deployment
Additional details or related context