refactor: Don't require explicitly pushing JinjavaInterpreter when using it directly#1285
Open
jasmith-hs wants to merge 1 commit intomasterfrom
Open
refactor: Don't require explicitly pushing JinjavaInterpreter when using it directly#1285jasmith-hs wants to merge 1 commit intomasterfrom
jasmith-hs wants to merge 1 commit intomasterfrom
Conversation
using a JinjavaInterpreter directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, anytime that you wanted to use
JinjavaInterpreter#renderorJinjavaInterpreter#parsedirectly, you'd need to push the interpreter onto the ThreadLocal stack.This PR moves the logic that pushes the current interpreter to instead be done inside of
JinjavaInterpreter#renderrather than withinJinjava#renderForResultto simplify the usage pattern.As part of doing this, I'm removing the direct dependency on
JinjavaInterpreter.getCurrent()from parsing by moving theWhitespaceControlParserto be injected in the constructor, similar toTokenScannerSymbols.Part of the reason why I'm doing this is because I'm going to make JinjavaBeanELResolver require a current JinjavaInterpreter in a 3.0 release of Jinjava and by pushing automatically, I can help make that more seamless for anyone that may be using a
JinjavaInterpreterdirectly as opposed to using aJinjava