Skip to content

HtmlPage: fix a bug where async script may not be executed #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbri merged 1 commit into from
Mar 13, 2026
+30 −0
Merged

HtmlPage: fix a bug where async script may not be executed #1100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/org/htmlunit/html/HtmlPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,8 @@ public void initialize() throws IOException, FailingHttpStatusCodeException {
executeEventHandlersIfNeeded(Event.TYPE_READY_STATE_CHANGE);
}

executePostponedScriptsIfNeeded();

executeDeferredScriptsIfNeeded();

executeEventHandlersIfNeeded(Event.TYPE_DOM_DOCUMENT_LOADED);
Expand Down Expand Up @@ -1477,6 +1479,13 @@ private String getRefreshStringOrNull() {
return getWebResponse().getResponseHeaderValue("Refresh");
}

private void executePostponedScriptsIfNeeded() {
if (!getWebClient().isJavaScriptEnabled()) {
return;
}
getWebClient().getJavaScriptEngine().processPostponedActions();
}

/**
* Executes any deferred scripts, if necessary.
*/
Expand Down
21 changes: 21 additions & 0 deletions src/test/java/org/htmlunit/html/HtmlPageTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1973,4 +1973,25 @@ public void getBaseUrl() throws Exception {
page = loadPage(getBrowserVersion(), html, null, new URL(URL_FIRST + path));
assertEquals(URL_FIRST.toExternalForm() + path, page.getBaseURL().toExternalForm());
}

/**
* @throws Exception if an error occurs
*/
@Test
public void asyncScriptExecutedWithoutEventHandlers() throws Exception {
final String html = DOCTYPE_HTML
+ "<html><head>\n"
+ "<script async src='async.js'></script>\n"
+ "</head><body></body></html>";

final WebClient client = getWebClient();
final MockWebConnection webConnection = new MockWebConnection();
webConnection.setDefaultResponse(html);
webConnection.setResponse(new URL(URL_FIRST, "async.js"),
"document.title = 'async-executed';", "text/javascript");
client.setWebConnection(webConnection);

final HtmlPage page = client.getPage(URL_FIRST);
assertEquals("async-executed", page.getTitleText());
}
}
Loading