Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved from http networking to websockets for hooks invocation rather we have bidirectional communication now between compiler and orchestrator. There is no schema change, DB already has a column for port in plugin table.
We maintain a map of websocket connection, and we keep an account of pending request, this is still request-response model nothing inherent has changed just the networking layer is websocket now.
This improved upon the existing http netwroking, now our golang process can send message to orchestrator (posing as websocket client) there is a simple interface for messages implemented.
Right now we dont send a lot of info from compiler using the websockets, only sending critical errors propagating in hook invocation and their success message.
Earlier we sent
taskId
andpluginDir
as headersNow we can just send them as regular payload.
We have a lot of errors already propagated to hook layer and then being sent to client, looks somewhat liks this
