Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netatalk 4.1.0 #203754

Merged
merged 2 commits into from
Jan 12, 2025
Merged

netatalk 4.1.0 #203754

merged 2 commits into from
Jan 12, 2025

Conversation

EricFromCanada
Copy link
Member

@EricFromCanada EricFromCanada commented Jan 9, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Add caveat with instructions for enabling authenticating as a system user on ARM-based macOS.

@github-actions github-actions bot added the perl Perl use is a significant feature of the PR or issue label Jan 9, 2025
@daeho-ro daeho-ro changed the title netatalk 4.0.9 netatalk 4.1.0 Jan 12, 2025
@EricFromCanada EricFromCanada force-pushed the netatalk-409 branch 2 times, most recently from 55e5434 to 18d1fd1 Compare January 12, 2025 05:17
@EricFromCanada EricFromCanada marked this pull request as ready for review January 12, 2025 05:18
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Linux build has linkage to linux-pam. Other than that LGTM.

daeho-ro
daeho-ro previously approved these changes Jan 12, 2025
@daeho-ro daeho-ro dismissed their stale review January 12, 2025 05:36

linux-pam linkeage

Copy link
Contributor

⚠️ Pre-merge checks failed.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 12, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 12, 2025 09:27
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 12, 2025
Merged via the queue into master with commit 89f0a1a Jan 12, 2025
15 checks passed
@BrewTestBot BrewTestBot deleted the netatalk-409 branch January 12, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. perl Perl use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants