code-server 4.6.1 #109430
Closed
code-server 4.6.1 #109430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
bump-formula-pr
Error: An exception occurred within a child process:
NameError: uninitialized constant Language::NodeHmm... gotta figure this out |
carlocab
reviewed
Sep 2, 2022
| @@ -27,7 +28,7 @@ class CodeServer < Formula | |||
|
|
|||
| def install | |||
| node = Formula["node@16"] | |||
| system "yarn", "--production", "--frozen-lockfile" | |||
| system "npm", "install", *Language::Node.std_npm_install_args(libexec), "--unsafe-perm" | |||
| # @parcel/watcher bundles all binaries for other platforms & architectures | |||
| # This deletes the non-matching architecture otherwise brew audit will complain. | |||
| prebuilds = buildpath/"lib/vscode/node_modules/@parcel/watcher/prebuilds" | |||
There was a problem hiding this comment.
Try removing the two rmtrees below, including this line.
There was a problem hiding this comment.
Thank you! I'll try that now.
|
Really not sure on this one. The modules should be there but they're not. Going to see if I can reproduce locally and debug. |
|
Roughly speaking, this is what should be happening:
|
|
Looks like we need a change in code-server to fix this. Once we do that, I'll update this PR. Relevant changes: coder/code-server#5533 |
4 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with
brew bump-formula-prin favor of #109321