Refactor: collapsing algorithm interaction based #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lorenzobattistela
force-pushed
the
collapser
branch
2 times, most recently
from
23d936e to
f389e0f
Compare
Lorenzobattistela
force-pushed
the
collapser
branch
from
f0392fd to
6ac6d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the collapsing algorithm to follow the one implemented in
HVM-Nanoand keep it in parity. It is significantly simpler and easy to understand.For now this is a WIP because it misses some constructors that HVM-Nano does not have, but I opened the PR so if Victor wants to test stuff quickly, it's already there for programs that are equivalent in HVM-Nano (they're compatible).