Skip to content

[#100] RPM spec fixes#99

Closed
kolyshkin wants to merge 1 commit intoHighResMusicPlayer:mainfrom
kolyshkin:fix-rpm
Closed

[#100] RPM spec fixes#99
kolyshkin wants to merge 1 commit intoHighResMusicPlayer:mainfrom
kolyshkin:fix-rpm

Conversation

@kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Jan 24, 2026

Bring the spec file to the working state:

  1. Replace chrpath with cmake option -DCMAKE_SKIP_RPATH=true to fix
    all the check-rpaths warnings.

  2. Fix a build failure caused by missing mkdir.

  3. Fix a typo in ncurses-lib package name.

While at it, fix/simplify rpm build instructions in doc/RPM.md.

@jesperpedersen
Copy link
Contributor

@kolyshkin Could you add yourself to https://github.com/HighResMusicPlayer/hrmp/blob/main/doc/DEVELOPERS.md#authors and squash the commits ? Thanks !

@jesperpedersen
Copy link
Contributor

Please, do [#100] RPM spec fixes as the commit message

Bring the spec file to the working state:

1. Replace chrpath with cmake option -DCMAKE_SKIP_RPATH=true to fix
   all the check-rpaths warnings.

2. Fix a build failure caused by missing mkdir.

3. Fix a typo in ncurses-lib package name.

While at it, fix/simplify rpm build instructions in doc/RPM.md.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin changed the title Fix spec file and rpm build docs [#100] RPM spec fixes Jan 26, 2026
@kolyshkin
Copy link
Contributor Author

Commits squashed; commit/PR title and description updated.

Could you add yourself to https://github.com/HighResMusicPlayer/hrmp/blob/main/doc/DEVELOPERS.md#authors

I do not consider myself an author, I'm merely a minor contributor fixing the issue I came across. If there would be a "contributors" list, I can add myself to it.

@jesperpedersen
Copy link
Contributor

@kolyshkin It is a contribution that adds value, so I think you should add yourself to the authors. But, it is your choice of course

@jesperpedersen
Copy link
Contributor

@kolyshkin Maybe you can integrate something like, pgagroal/pgagroal@ae6c369

@kolyshkin
Copy link
Contributor Author

@kolyshkin Maybe you can integrate something like, pgagroal/pgagroal@ae6c369

Can certainly do that, but that's a separate task. This PR merely fixes the non-working rpm build.

Will take a closer look tomorrow if time permits.

@jesperpedersen jesperpedersen added enhancement Improvement to an existing feature bug Something isn't working and removed enhancement Improvement to an existing feature labels Feb 2, 2026
@jesperpedersen
Copy link
Contributor

Rebased, and merged.

Thanks for your contribution !

@jesperpedersen
Copy link
Contributor

@kolyshkin Hopefully you can contribute addional improvements for the RPM build chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants