Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make SettingType.select inferring options as type #753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make SettingType.select inferring options as type #753

wants to merge 1 commit into from

Conversation

yassinedorbozgithub
Copy link
Collaborator

Motivation

The main motivation is to make setting with SettingType.select type inferring the options types.

Fixes #752

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@yassinedorbozgithub yassinedorbozgithub added the enhancement New feature or request label Feb 14, 2025
@yassinedorbozgithub yassinedorbozgithub self-assigned this Feb 14, 2025
@yassinedorbozgithub yassinedorbozgithub linked an issue Feb 14, 2025 that may be closed by this pull request
🤔 [ISSUE] - make SettingType.select return options type instead returning a string type #752
Open
@marrouchi marrouchi requested a review from abdou6666 February 14, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IkbelTalebHssan IkbelTalebHssan IkbelTalebHssan approved these changes

@abdou6666 abdou6666 Awaiting requested review from abdou6666

At least 2 approving reviews are required to merge this pull request.

Assignees

@yassinedorbozgithub yassinedorbozgithub

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤔 [ISSUE] - make SettingType.select return options type instead returning a string type
2 participants
@yassinedorbozgithub @IkbelTalebHssan