-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cleanup orphan extensions' settings #646
base: main
Are you sure you want to change the base?
feat: Cleanup orphan extensions' settings #646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we make the service part of the setting module, let's call it CleanUpService.
Let's for now handle only channels and helpers.
I think that making the new |
@yassine-sallemi Then I suggest we add onModuleInit for each module (HelperService, ChannelService), so each one cleans up his own settings. |
9a2b80f
to
a372529
Compare
a372529
to
eacd1a1
Compare
Motivation
Unnecessary settings of orphan extensions are now deleted to avoid errors in frontend
Type of change:
Checklist: