Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): allow fallback block to be empty #554

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omarNaifer12
Copy link

@omarNaifer12 omarNaifer12 commented Jan 11, 2025

The backend does not allow fallback_block to be null it only allows it to be a string.

Fixes #553

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@medchedli medchedli added the SWOC Social Winter of Code 2025 label Jan 13, 2025
Copy link
Contributor

@MohamedAliBouhaouala MohamedAliBouhaouala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase.

git checkout main
git pull upstream main
git checkout issue-553-fallback-block-can-be-empty
git rebase main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review SWOC Social Winter of Code 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Internal server error when setting the fallback block to empty
5 participants