fix(BtnDisplayRename_Click)：在重命名前检查路径 #5773
Open
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimoranla
changed the title
|
没有 Review 的坏处：写错了也没人提醒下我.jpg (玩笑，无恶意) |
|
|
|
如果预先输入好，然后去资源管理器建一个目录，再切回去不会有重复提示，因为文本压根就没变过也不会触发检查，这个时候确认重命名就能复现这个 Bug |
This comment was marked as outdated.
This comment was marked as outdated.
|
在弹窗的实现里写点确定按钮之后再给文本输入框 Validate 一下（ 不然这没法确定弹窗获取到的输入一定有效，在别的地方用也有可能出 bug ，对吧（ Edit: 这个应该放在 MyConverter.IsExited 后面
|
|
我中午再看看怎么写比较好 |
|
现在造成这个 bug 的原因就是只在用户输入内容发生改变时才会 TextArea.Validate() ，这设计就导致了 Validate 类不能做成“在外界发生改变时判断结果有可能改变”的样子，否则就有可能将实际上通不过检查的内容返回出去。在返回结果之前也进行一次有效性判断就能解决这个问题。 |
|
中午再说.jpg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #5304