-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cppia] Generate scriptable functions for overriden functions #11773
Conversation
Does this interact with overloads somehow given that we're comparing methods by name? |
I don't think so. Overloads only really work on extern classes iirc, and that code is only ran on haxe classes and interfaces. |
This fix doesn't seem to have released a new haxe yet. Can I get a new haxe executable file from the nightly build? Which one is stable? (Mac user) |
4.3 bug fix did not update this modification. Can it be fixed in 4.3? |
src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp
Error: ./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:141:13: error: invalid covariant return type for 'virtual Dynamic haxe::ds::_GenericStack::GenericStackIterator_hscript_Token_obj__scriptable::next()'
::Dynamic next( ) {
^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:48:19: error: overriding 'virtual hscript::Token haxe::ds::_GenericStack::GenericStackIterator_hscript_Token_obj::next()'
::hscript::Token GenericStackIterator_hscript_Token_obj::next(){
^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:152:55: warning: 'fastcall' attribute directive ignored [-Wattributes]
static void CPPIA_CALL __s_hasNext(::hx::CppiaCtx *ctx) {
^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:157:52: warning: 'fastcall' attribute directive ignored [-Wattributes]
static void CPPIA_CALL __s_next(::hx::CppiaCtx *ctx) {
^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:171:67: warning: 'fastcall' attribute directive ignored [-Wattributes]
static void CPPIA_CALL __script_construct_func(::hx::CppiaCtx *ctx) { I have tried this fix, but compilation errors occur. |
Even with this PR, the test cases cannot pass. This is my issues. |
Fixes HaxeFoundation/hxcpp#1150
Test has been added in this hxcpp merge HaxeFoundation/hxcpp#1154
That hxcpp merge is failing due to the new test, once this is merged the CI on that hxcpp merge should be re-ran and it will then pass.