Sample Docker App #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@battosai-slayer864 what happens when you click the links above, please post the output? |
|
|
||
| ## Getting Started | ||
|
|
||
| If you wish to run the tutorial, you can use the following command after installing Docker Desktop: |
There was a problem hiding this comment.
explain docker compose and why it is used here
|
|
||
| const expectedItem = { id, name, completed: false }; | ||
|
|
||
| expect(db.storeItem.mock.calls.length).toBe(1); |
There was a problem hiding this comment.
It appears you have an online store here, please post in your pull request all of this application showing it working
|
Why are you calling port 8000? But your demo shows 3000?
|
|
It seems a bit extreme for a sample application, however when you introduce 82 new files, they will need to be explained: Docker/Docker_Apps_ and_Practice/getting-started/docs/tutorial/sharing-our-app/index.md Where did this come from ^ ? |
|
Why are you holding both mysql and sqlite? Docker/Docker_Apps_ and_Practice/getting-started/app/package.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this branch and followed Docker Docs TO DO LIST, Sample Application which I tested and it works. This is a step forward in understanding Docker and how to use it for future Python apps deployment.
Below is a screenshot of the sample web app with two items added.