Skip to content

fix(ui-react): use semantic map marker token#2914

Open
ctwoodwa wants to merge 1 commit into
mainfrom
fix/deckhand-w3-2570-map-semantic-token
Open

fix(ui-react): use semantic map marker token#2914
ctwoodwa wants to merge 1 commit into
mainfrom
fix/deckhand-w3-2570-map-semantic-token

Conversation

@ctwoodwa

Copy link
Copy Markdown
Contributor

Summary

  • Replaces the Map story marker's raw blue hex with the semantic active-accent token.

Validation

  • Focused Map tests, token-discipline, scope, typecheck, build/no-diff, and source scan pass.
  • Local Storybook build is blocked by the Windows sandbox's denied ancestor traversal; fresh CI is required for its light/dark axe jobs.

Closes #2570

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ctwoodwa, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f38bd9b6-fde8-43aa-a1ca-3901a9609364

📥 Commits

Reviewing files that changed from the base of the PR and between 2f6104c and 5cefa4c.

📒 Files selected for processing (1)
  • packages/ui-react/src/components/layout/Map.stories.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deckhand-w3-2570-map-semantic-token

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

thought (non-blocking):

Accessibility audit (advisory)

The sharded axe audit is report-only while the baseline and runtime budget mature.
Unknown moderate-or-higher findings must be resolved or added to the reviewed
accessibility baseline.

Shard Result Findings
1/4 pass 0 axe finding(s), 1 coverage warning(s)
2/4 pass 0 axe finding(s), 1 coverage warning(s)
3/4 pass 0 axe finding(s), 1 coverage warning(s)
4/4 pass No moderate-or-higher findings
Shard 1 report
[shipyard-syncstate-indicator] skipping directionalIcons enforcement: component has not opted in via [data-shipyard-direction="<state>"] sentinel.
Shard 2 report
[shipyard-button] skipping keyboardMap enforcement: component has not opted in via data-shipyard-keyboard-map="enabled".
Shard 3 report
[shipyard-dialog] skipping keyboardMap enforcement: component has not opted in via data-shipyard-keyboard-map="enabled".

@ctwoodwa

Copy link
Copy Markdown
Contributor Author

APPROVE — exact head 5cefa4cd2f5ca56c091501b7e08b3f461b658f33.

The story now uses the current card-adjudicated semantic marker value, var(--color-accent-active). That token resolves independently in the shipped light and dark themes, and the shared CITIES fixture still exercises the MapMarker.color override across Default, Zoomed, and WithPopup without changing component behavior.

Independent local evidence: focused Map tests 13/13; scope-bleed; token discipline (0 findings); one-file scope/raw-color/source scan; typecheck; production build; and generated JS/CJS/DTS no-diff all passed. The Windows sandbox reproduced the documented Storybook ancestor-traversal block before story compilation; exact-head CI supplies the platform evidence: ui-react Storybook/axe light and dark each passed 196 suites / 898 tests, the Chromium visual run passed 196 suites / 898 tests, and all 48 head contexts are terminal-success or intentional skip.

No raw-color, generated-output, story-behavior, or accessibility drift survived review. PR remains unarmed and unmerged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Story-token sweep: Map story — raw colors to semantic tokens

1 participant