Subsystem 6b: Item DB decay + upkeep calculators (/decay /upkeep + in-game, schema v2)#29
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ter (6b) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…6b review) - EmbeddedItemDatabaseTests: Assert.Single on WoodenDoor upkeep entry with ItemId/QuantityMin/QuantityMax - DecayFormatterTests: add DecayLine_ShowsDashAndHpWhenNoDecaySeconds fact; assert HP(250) in variant test - Strings.resx + Strings.fr.resx: append period to help.slash.decay and help.slash.upkeep values Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second slice of the item-database subsystem (after 6a, #28). Extends the bundled dataset with two new per-item attributes — decay and upkeep — and ships matching calculators on both surfaces: in-game
!decay/!upkeepand Discord/decay//upkeep. A faithful mirror of 6a's/recycle//craft//research.What's in it
Features.ItemData) —ItemRecordgains nullableDecay(DecayInfo: seconds + 4 env variants + HP) andUpkeep(UpkeepCost/UpkeepEntry: resource id + min/max quantity).DatasetSourcesgainsDecayAsOf/UpkeepAsOf. Schema version bumped 1 → 2 (loader rejects a mismatched bundle).tools/RustPlusBot.ItemData.Generator) —LoadDecay/LoadUpkeepread the"items"-wrapped RustLabs files; a pureUpkeepQuantity.Parseturns"1"/ en-dash ranges"8–25"into structuredmin/maxand fails loud on anything else;DatasetValidatorgains upkeep-id-resolves /min ≤ max/ non-negative-decay checks. The embeddeditem-data.jsonwas regenerated (1205 items, schemaVersion 2, 0 orphan decay/upkeep entries — 137 decay + 26 upkeep attached).Features.Commands) — pureDecayLine/UpkeepLineformatters, in-gameDecayCommandHandler/UpkeepCommandHandler, two[SlashCommand]s onItemCommandModule, EN/FR strings, and the/helpcatalog. The slash footer now shows each command's own section date (small refactor of the shared helper).Scope / deferrals
Quality gates
-warnaserror, strict Roslynator/Sonar).-maxcpucount:1); no assembly dropped.jb cleanupcode --profile=ReformatAndReorderzero-diff.Features.ItemDatastays a dependency-free leaf.🤖 Generated with Claude Code