put default value to metaArr

maybe the programmer used the same names of the framework, so he would't need to put a metaArr, and that will make app not worrking & this is a problem so i fixed it now.
HamzaElkotp · Sep 22, 2022 · 76bf247 · 76bf247
1 parent 35cfc66
commit 76bf247
Show file tree

Hide file tree

Showing 3 changed files with 20,012 additions and 20 deletions.
diff --git a/main.css b/main.css
@@ -52,4 +52,3 @@ body{
 
 
 
-
diff --git a/main.js b/main.js
@@ -1,4 +1,5 @@
-function jsonRead(jsonpages, metatagArr){
+function jsonRead(jsonpages, metatagArr = ["SPAname", "SPAurl", "SPAtitle"]){
+
     let xhr = fetch(jsonpages);
     xhr.then((res)=>{
         return res.json()
@@ -19,11 +20,14 @@ function jsonRead(jsonpages, metatagArr){
                 ele.addEventListener('click',()=>{
 
                     // change title, url   regardless of pages or json file objects order
-                    data.forEach((item, dataI)=>{
+                    data.evry((item, dataI)=>{
                         if(data[dataI][SPAname] == ele.getAttribute("SPAname")){
                             document.title = data[dataI][SPAtitle];
                             window.history.pushState("","",data[dataI][SPAurl]);
+                            return false;
                         }
+                        console.log(1)
+                        return true;
                     })
 
                     elements.forEach((eles)=>{
@@ -38,9 +42,7 @@ function jsonRead(jsonpages, metatagArr){
     });
 }
 
-jsonRead("spa.json",["SPAnameR", "SPAurlR", "SPAtitleR"]);
-
-
-
+jsonRead("spa.json",["SPAname1", "SPAurl1", "SPAtitle1"]);
 
 
+// You have a problem, many requests, to window.history.pushState  because looping on every element