-
Notifications
You must be signed in to change notification settings - Fork 18
Update website content: add news posts, update config, structure upd. #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All is good, can you just please revert the footer? We should give them credit. Other stuff is trivial, I just wrote them to give a feedback in general, they don't need to be changed.
_includes/footer.html
Outdated
| {{ site.title }} | ||
| | Built with | ||
| <a href="https://github.com/greenelab/lab-website-template"> | ||
| Lab Website Template | ||
| </a> | ||
| Hacettepe University Biological Data Science Laboratory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to give them credit, so it should stay as is.
_includes/footer.html
Outdated
| <footer | ||
| class="background" | ||
| style="--image: url('{{ image | relative_url | uri_escape }}')" | ||
| {% if dark == true or dark == false %} | ||
| data-dark="{{ dark }}" | ||
| {% endif %} | ||
| data-size="wide" | ||
| > | ||
| <footer class="background" style="--image: url('{{ image | relative_url | uri_escape }}')" {% if dark==true or | ||
| dark==false %} data-dark="{{ dark }}" {% endif %} data-size="wide"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just formatting right? If that's the case, it's better to do it in a seperate commit.
_includes/footer.html
Outdated
| {% assign key = link[0] %} | ||
| {% assign value = link[1] %} | ||
| {% include button.html type=key text="" link=value style="bare" %} | ||
| {% assign key = link[0] %} | ||
| {% assign value = link[1] %} | ||
| {% include button.html type=key text="" link=value style="bare" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just formatting right? If that's the case, it's better to do it in a seperate commit.
_includes/footer.html
Outdated
| <input | ||
| type="checkbox" | ||
| class="dark-toggle" | ||
| data-tooltip="Dark mode" | ||
| aria-label="toggle dark mode" | ||
| oninput="onDarkToggleChange(event)" | ||
| > | ||
| </footer> | ||
| <input type="checkbox" class="dark-toggle" data-tooltip="Dark mode" aria-label="toggle dark mode" | ||
| oninput="onDarkToggleChange(event)"> | ||
| </footer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just formatting right? If that's the case, it's better to do it in a seperate commit.
_includes/post-info.html
Outdated
| {% assign authors = include.author | ||
| | join: "," | ||
| | downcase | ||
| | split: "," | ||
| | array_filter | ||
| %} | ||
| {% for author in authors %} | ||
| {% assign member = site.members | ||
| | where_exp: "member", "member.slug == author" | ||
| | first | ||
| %} | ||
| {% if member %} | ||
| {% include portrait.html lookup=author style="tiny" %} | ||
| {% else %} | ||
| <span data-tooltip="Author"> | ||
| {% include icon.html icon="fa-solid fa-feather-pointed" %} | ||
| <span>{{ author }}</span> | ||
| </span> | ||
| {% endif %} | ||
| {% endfor %} | ||
| {% assign authors = include.author | ||
| | join: "," | ||
| | downcase | ||
| | split: "," | ||
| | array_filter | ||
| %} | ||
| {% for author in authors %} | ||
| {% assign member = site.members | ||
| | where_exp: "member", "member.slug == author" | ||
| | first | ||
| %} | ||
| {% if member %} | ||
| {% include portrait.html lookup=author style="tiny" %} | ||
| {% else %} | ||
| <span data-tooltip="Author"> | ||
| {% include icon.html icon="fa-solid fa-feather-pointed" %} | ||
| <span>{{ author }}</span> | ||
| </span> | ||
| {% endif %} | ||
| {% endfor %} | ||
| {% endif %} | ||
|
|
||
| {% assign published = include.published | date: "%B %d, %Y" %} | ||
| {% assign updated = include.updated | date: "%B %d, %Y" %} | ||
|
|
||
| {% if published %} | ||
| <span data-tooltip="Originally published on"> | ||
| {% include icon.html icon="fa-regular fa-calendar" %} | ||
| <span>{{ published }}</span> | ||
| </span> | ||
| <span data-tooltip="Originally published on"> | ||
| {% include icon.html icon="fa-regular fa-calendar" %} | ||
| <span>{{ published }}</span> | ||
| </span> | ||
| {% endif %} | ||
|
|
||
| {% if updated and updated != "" and updated != published %} | ||
| <span data-tooltip="Last updated on"> | ||
| {% include icon.html icon="fa-solid fa-clock-rotate-left" %} | ||
| <span>{{ updated }}</span> | ||
| </span> | ||
| <span data-tooltip="Last updated on"> | ||
| {% include icon.html icon="fa-solid fa-clock-rotate-left" %} | ||
| <span>{{ updated }}</span> | ||
| </span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just formatting right? If that's the case, it's better to do it in a seperate commit.
_includes/post-info.html
Outdated
| {% if include.tags %} | ||
| {% include tags.html tags=include.tags link="blog" %} | ||
| {% endif %} | ||
| {% include tags.html tags=include.tags link="news" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except the formatting, as mentioned before.
_layouts/member.html
Outdated
| {% assign key = link[0] %} | ||
| {% assign value = link[1] %} | ||
| {% include button.html type=key link=value style="bare" %}<br> | ||
| {% assign key = link[0] %} | ||
| {% assign value = link[1] %} | ||
| {% include button.html type=key link=value style="bare" %}<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just formatting right? If that's the case, it's better to do it in a seperate commit.
_layouts/member.html
Outdated
| | default: page.name | ||
| | default: page.title | ||
| | join: "," | ||
| | split: "," | ||
| | array_filter | ||
| | default: page.name | ||
| | default: page.title | ||
| | join: "," | ||
| | split: "," | ||
| | array_filter | ||
| %} | ||
|
|
||
| {% capture search -%} | ||
| research/?search={% for alias in aliases %}"{{ alias }}" {% endfor %} | ||
| research/?search={% for alias in aliases %}"{{ alias }}" {% endfor %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just formatting right? If that's the case, it's better to do it in a seperate commit.
Added 7 new news posts covering recent lab activities:
Reorganized blog section → news section
Updated navigation and page structure
Added new image assets for news and sections
Updated
_config.yamlwith new info (fixed wrong footer's links)Updated footer and post information displays
Removed default txts, added some description