Skip to content

feat: merge screenshot mode into make picture menu (#540)#802

Open
DhanashreePetare wants to merge 1 commit intoHSF:mainfrom
DhanashreePetare:feature/merge-screenshot-picture-540
Open

feat: merge screenshot mode into make picture menu (#540)#802
DhanashreePetare wants to merge 1 commit intoHSF:mainfrom
DhanashreePetare:feature/merge-screenshot-picture-540

Conversation

@DhanashreePetare
Copy link
Contributor

Description

Fixes #540

This PR merges “screenshot mode” and “make picture” into a single menu entry, reducing UI confusion. The screenshot mode toggle now lives inside the make‑picture menu, while still preserving fullscreen behavior and UI hiding during screenshot mode.

Changes

  • Merged screenshot mode controls into the make‑picture menu.
  • Removed the separate screenshot mode button from the UI menu and LHCb section.
  • Preserved screenshot mode behavior (fullscreen + UI hidden via .ss-mode), now scoped to the make‑picture component.
  • Added tests for screenshot mode toggle in the make‑picture component.

Behavior

  • Click Make Picture → menu opens with options:
    • Enter/Exit screenshot mode
    • Set size/fitting and save picture
  • Exiting fullscreen automatically leaves screenshot mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge screenshot and make picture buttons

1 participant

Comments