fix: Fix handling of ATLAS AOD files with specific compression method#710
Open
AritraDey-Dev wants to merge 1 commit intoHSF:mainfrom
Open
fix: Fix handling of ATLAS AOD files with specific compression method#710AritraDey-Dev wants to merge 1 commit intoHSF:mainfrom
AritraDey-Dev wants to merge 1 commit intoHSF:mainfrom
Conversation
Fixes HSF#44 Update `JSRootEventLoader` to handle unsupported compression method for ATLAS AOD files. * Add import for the compression library in `packages/phoenix-event-display/src/loaders/jsroot-event-loader.ts`. * Modify `getEventData` method to handle unsupported compression errors. * Add `handleUnsupportedCompression` method to decompress data and read objects from the file. * Add tests in `packages/phoenix-event-display/src/tests/loaders/jsroot-event-loader.test.ts` to verify handling of ATLAS AOD files with the new compression method. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/HSF/phoenix/issues/44?shareId=XXXX-XXXX-XXXX-XXXX).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44
Update
JSRootEventLoaderto handle unsupported compression method for ATLAS AOD files.packages/phoenix-event-display/src/loaders/jsroot-event-loader.ts.getEventDatamethod to handle unsupported compression errors.handleUnsupportedCompressionmethod to decompress data and read objects from the file.packages/phoenix-event-display/src/tests/loaders/jsroot-event-loader.test.tsto verify handling of ATLAS AOD files with the new compression method.