-
Notifications
You must be signed in to change notification settings - Fork 367
feat(gsoc): Negative Weights #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for earnest-hotteok-b1e1bf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@graeme-a-stewart @eduardo-rodrigues Tagging admins |
|
label:"GSoC" |
maszyman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the proposals.
Please have a look at my comments inline.
Also, please consider adding AI policy, for example as suggested in #1804 (comment)
| - | ||
| project: HSF | ||
| title: HSF | ||
| layout: default | ||
| logo: hsf_logo_angled.png | ||
| description: | | ||
| The HEP Software Foundation encourages cooperation and common | ||
| development of software in High Energy Physics. The HSF hosts | ||
| a number of software projects where developers are working to | ||
| solve current problems in particle physics. | ||
| --- | ||
|
|
||
| {% include gsoc_project.ext %} | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem to be needed. Please have a loot at template in e.g. #1804
| - | ||
| title: Negative weight mitigation with cell resampling in ATLAS workflows | ||
| layout: gsoc_proposal | ||
| project: Negative weight, ATLAS event generator workflows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should correspond to the project that needs to be defined in _gsocproject/2026/. We already have there ATLAS is that what this proposal targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| project: Negative weight, ATLAS event generator workflows | |
| project: ATLAS |
| layout: gsoc_proposal | ||
| project: Negative weight, ATLAS event generator workflows | ||
| year: 2026 | ||
| organization: Southern Methodist University |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name should correspond to the definition in _gsocorgs/2026. Please check the examples, but you may need to create smu.md in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| organization: Southern Methodist University | |
| organization: SMU |
|
|
||
| Negatively weighted events arise as a result of subtraction schemes in next-to-leading (or higher) order event generators. The fraction of negatively weighted events vary as a function of phase space requirements that are imposed in experimental analyses making it imperative to store these events for time consuming downstream processing like detector simulation. They are a severe source of inefficiency in event generator workflows, requiring large datasets to mitigate statistical dilution caused by negatively weighted events. | ||
|
|
||
| A method to redistribute negatively weighted events was proposed in arXiv:2109.07851 and subsequently in arXiv:2303.15246. We plan to use this method for ATLAS event generator workflows. The method has been previously implemented in CMS for small-scale tests. In this project, we will extend the scope of previous explorations in both ATLAS and CMS by identifying computationally intensive workflows and running validation tests that are designed to ensure that distributions of physical observables are not sculpted as a result of the removal of negatively weighted events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make those arXiv references the clickable links.
| * Design an event generator workflow and validation suite that tests the cell resampling method for negative weight removal | ||
|
|
||
| ## Requirements | ||
| * Familiarity with python and C++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Familiarity with python and C++ | |
| * Familiarity with Python and C++ |
| * [Saptaparna Bhattacharya](mailto:saptaparna.bhattacharya@cern.ch) | ||
|
|
||
| ## Links | ||
| * [Cell resampling](https://cres.hepforge.org/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be a Rust project. Would it make sense to add it in requirements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
| @@ -0,0 +1,51 @@ | |||
| - | |||
| project: HSF | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same editorial comments as for the previous proposal.
|
|
||
| ## Expected results | ||
| Release a modified version of MCFM that successfully incorporates the negative weight mitigation strategy, demonstrating reduced statistical dilution. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing Mentors section (should be done via project_mentors in the metadata at the top).
If you are the only mentor also for this project, please consider adding a co-mentor as Google suggests that mentors should mentor 1 contributor project, and there should be preferably 2 mentors per project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
@Saptaparna could you please update the PR following the comments? |
|
@Saptaparna just a kind reminder to update this PR. |
|
@maszyman done! |
maszyman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. There are still a couple changes needed to properly render the project.
| layout: gsoc_proposal | ||
| project: Negative weight, ATLAS event generator workflows | ||
| year: 2026 | ||
| organization: Southern Methodist University |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| organization: Southern Methodist University | |
| organization: SMU |
| - | ||
| title: Negative weight mitigation with cell resampling in ATLAS workflows | ||
| layout: gsoc_proposal | ||
| project: Negative weight, ATLAS event generator workflows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| project: Negative weight, ATLAS event generator workflows | |
| project: ATLAS |
| @@ -0,0 +1,40 @@ | |||
| - | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - | |
| --- |
| difficulty: medium | ||
| duration: 175 | ||
| mentor_avail: June-October | ||
| project_mentors: Saptaparna Bhattacharya (saptaparnab@smu.edu) and authors of the "cell-resampling" team (Jeppe Andersen(mailto:eppe.andersen@durham.ac.uk) and Andreas Maier(mailto:andreas.martin.maier@desy.de)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| project_mentors: Saptaparna Bhattacharya (saptaparnab@smu.edu) and authors of the "cell-resampling" team (Jeppe Andersen(mailto:eppe.andersen@durham.ac.uk) and Andreas Maier(mailto:andreas.martin.maier@desy.de)) | |
| project_mentors: | |
| - email: saptaparnab@smu.edu | |
| first_name: Saptaparna | |
| last_name: Bhattacharya | |
| organization: SMU | |
| is_preferred_contact: yes |
and similarly for the co-mentors
| ## Mentors | ||
| * [Saptaparna Bhattacharya](mailto:saptaparna.bhattacharya@cern.ch) and authors of the "cell-resampling" team (Jeppe Andersen(mailto:eppe.andersen@durham.ac.uk) and Andreas Maier(mailto:andreas.martin.maier@desy.de)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## Mentors | |
| * [Saptaparna Bhattacharya](mailto:saptaparna.bhattacharya@cern.ch) and authors of the "cell-resampling" team (Jeppe Andersen(mailto:eppe.andersen@durham.ac.uk) and Andreas Maier(mailto:andreas.martin.maier@desy.de)) |
This is handled by project_mentors metadata
| - | ||
| title: Negative weight mitigation with cell resampling and tests with MCFM | ||
| layout: gsoc_proposal | ||
| project: Negative weight, MCFM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| project: Negative weight, MCFM | |
| project: MCFM |
and please add MCFM.md to _gsocprojects/2026/
| difficulty: medium | ||
| duration: 175 | ||
| mentor_avail: June-October | ||
| project_mentors: Tobias Neumann (tneumann@mail.smu.edu), Saptaparna Bhattacharya (saptaparnab@smu.edu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as previous proposal
|
AI policy is now there too. |
Updated organization details and mentor organization.
|
Thanks @Saptaparna , I've made few adjustments, but I think now it's ready. |
PR for two projects on negative weight mitigation.