Dont repeat dpss window calc #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aewallwi
force-pushed
the
dont_repeate_dpss_window_calc
branch
from
2ca7911 to
a21d485
Compare
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
==========================================
- Coverage 87.88% 87.83% -0.06%
==========================================
Files 7 7
Lines 1502 1504 +2
==========================================
+ Hits 1320 1321 +1
- Misses 182 183 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jsdillon
requested changes
Sep 20, 2021
| if fundamental_period is None: | ||
| fundamental_period = np.median(np.diff(x)) * len(x) | ||
| fundamental_period = np.median(np.diff(x)) * len(x) * 2 |
There was a problem hiding this comment.
I don't understand this change well enough to comment on it, so it's a bit concerning that it's not covered by unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate wasteful repeated calculation of DPSS vectors in dpss_operator method.
Depends on #138