Rewrite complex number configuration logic to fix re-configuration issue and improve clarity #6080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendersonHDF
commented
Dec 2, 2025
|
|
||
| # Check if __STDC_NO_COMPLEX__ macro is defined, in which case complex number | ||
| # support is not available | ||
| HDF_FUNCTION_TEST (HAVE_STDC_NO_COMPLEX) |
Collaborator
Author
There was a problem hiding this comment.
Moved this check to be first, as it is a standalone check that can tell us early if complex number support isn't available
jhendersonHDF
commented
Dec 2, 2025
| CHECK_INCLUDE_FILE (complex.h ${HDF_PREFIX}_HAVE_COMPLEX_H) | ||
| if (${HDF_PREFIX}_HAVE_COMPLEX_H) | ||
| # Check for C99 complex number types first | ||
| HDF_CHECK_TYPE_SIZE ("float _Complex" ${HDF_PREFIX}_SIZEOF_C99_FLOAT_COMPLEX) |
Collaborator
Author
There was a problem hiding this comment.
Changed the variable names for these size checks so they aren't mixed with the final names used by the macros in H5pubconf.h
jhendersonHDF
commented
Dec 2, 2025
| cmake_pop_check_state () | ||
| if (${HDF_PREFIX}_SIZEOF__FCOMPLEX AND ${HDF_PREFIX}_SIZEOF__DCOMPLEX AND | ||
| ${HDF_PREFIX}_SIZEOF__FCOMPLEX) | ||
| set (${HDF_PREFIX}_SIZEOF_FLOAT_COMPLEX ${${HDF_PREFIX}_SIZEOF__FCOMPLEX} |
Collaborator
Author
There was a problem hiding this comment.
Moved setting the final size macro variables to as late as possible and updated the check below to avoid issues with mixing up when a particular type of complex numbers are available
jhendersonHDF
force-pushed
the
rewrite_complex_config_logic
branch
from
fd495c8 to
9dfe4ec
Compare
…sue and improve clarity
jhendersonHDF
force-pushed
the
rewrite_complex_config_logic
branch
from
9dfe4ec to
984bfda
Compare
jhendersonHDF
requested review from
bmribler,
byrnHDF,
derobins,
fortnern,
glennsong09,
lrknox,
mattjala,
qkoziol and
vchoi-hdfgroup
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Rewrites complex number configuration logic in
ConfigureChecks.cmaketo improve clarity and fix re-configuration issues by restructuring checks for C99 and MSVC complex types.ConfigureChecks.cmaketo first check__STDC_NO_COMPLEX__macro.complex.hand C99 complex types (float _Complex,double _Complex,long double _Complex)._Fcomplex,_Dcomplex,_Lcomplex) if C99 types are unavailable.H5_HAVE_C99_COMPLEX_NUMBERSif C99 types are available.This description was created by
for 984bfda. You can customize this summary. It will automatically update as commits are pushed.