Skip to content

Conversation

@derobins
Copy link
Member

@derobins derobins commented Nov 9, 2025

Adds an HDF5_USE_IWYU option to CMake (default OFF).
This will run the include-what-you-use tool while compiling.

See https://include-what-you-use.org/ for more information.

This requires include-what-you-use to be installed.

Addresses #6001


Important

Adds HDF5_USE_IWYU option to CMake to run include-what-you-use during compilation, documented in CHANGELOG.md.

  • CMake Configuration:
    • Adds HDF5_USE_IWYU option to CMakeLists.txt to run include-what-you-use during compilation (default OFF).
    • Requires include-what-you-use to be installed.
  • Documentation:
    • Updates CHANGELOG.md to document the new HDF5_USE_IWYU option.

This description was created by Ellipsis for 8638293. You can customize this summary. It will automatically update as commits are pushed.

@derobins
Copy link
Member Author

derobins commented Nov 9, 2025

The suggestions it emits are not very useful at this time due to the way we use H5public.h / H5private.h and the large number of implicit includes in the code. It'll be a useful tool when fixing problems, though.

Definitely don't want to run the auto-fix tool - that'd make a huge mess...

@byrnHDF
Copy link
Contributor

byrnHDF commented Nov 9, 2025

Adds include-what-you-use to code compiled after this macro. All arguments are

added to the include-what-you-use application call in the form of

include-what-you-use ${ARGN}.

This is in the tools.cmake file under config/sanitizer

@derobins
Copy link
Member Author

derobins commented Nov 9, 2025

Adds include-what-you-use to code compiled after this macro. All arguments are

added to the include-what-you-use application call in the form of

include-what-you-use ${ARGN}.

This is in the tools.cmake file under config/sanitizer

So should this be closed?

@byrnHDF
Copy link
Contributor

byrnHDF commented Nov 9, 2025

So should this be closed?

IDK, are they the same and does the tools.cmake one work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To be triaged

Development

Successfully merging this pull request may close these issues.

3 participants