Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new themes optimised for OLED displays and visually impaired users #708

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

ZeroDot1
Copy link
Contributor

@ZeroDot1 ZeroDot1 commented Feb 7, 2025

Hello everyone,,
I have created a new theme for visually impaired people and at the same time compatible with OLED screens. I hope this will help to improve the usability of the program for visually impaired people (I am visually impaired myself).
Bildschirmfoto_20250207_174319

Hello everyone,,
I have created a new theme for visually impaired people and at the same time compatible with OLED screens.
I hope this will help to improve the usability of the program for visually impaired people (I am visually impaired myself).
@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 7, 2025

Wow, that's an amazing idea!

What about expanding it a little further?
Following your idea, I'd now like to provide two new themes for visually impaired people directly inside the application.

Could you create one dark palette & one light palette especially designed for visually impaired people?
Such palettes don't have to follow the original colour scheme, use what's really best for this user group.

It's fine if you just create two TOML files, I'll add the themes to the app myself.

@GyulyVGC GyulyVGC added this to the v1.4.0 milestone Feb 7, 2025
@GyulyVGC GyulyVGC added the design Styling and appearance label Feb 7, 2025
@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 7, 2025

Maybe create something ideal for colour-blind people?

@ZeroDot1
Copy link
Contributor Author

ZeroDot1 commented Feb 7, 2025

Hi @GyulyVGC, thank you, I have added a bright theme, it contains the exat negative colors, which works just as well for people with visual impairment. I have adjusted the orange and blue in both themes so that the colors are not blinding. This is especially important for people with a cataract. #709

@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 7, 2025

Thank you again @ZeroDot1

If you have any suggestions on how to name them, let me know.
I'll display their names in the application themes page.
I'd like to name them in a way such that it's clear that these are thought for people with visual impairments.

@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 7, 2025

In the end I've simply called them OLED, and they're now featured in-app!

Screenshot 2025-02-07 at 23 14 53

@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 7, 2025

@all-contributors please add @ZeroDot1 for design, a11y.

Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @ZeroDot1! 🎉

@GyulyVGC GyulyVGC merged commit 793a4fc into GyulyVGC:main Feb 7, 2025
3 checks passed
@GyulyVGC GyulyVGC changed the title Create the new theme sniff_oled.toml Create the new themes optimised for OLED displays and visually impaired users Feb 7, 2025
@GyulyVGC GyulyVGC changed the title Create the new themes optimised for OLED displays and visually impaired users Create new themes optimised for OLED displays and visually impaired users Feb 7, 2025
@ZeroDot1
Copy link
Contributor Author

ZeroDot1 commented Feb 8, 2025

Hi @GyulyVGC, thank you for adding the themes to the program. I recommend renaming the bright theme to paper or LCD, bright themes are often used with LED/LCD and color E Ink displays.

@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 8, 2025

Mm, I understand. However, I'd like them to have the same name to follow the already existing themes. Any other ideas?

@ZeroDot1
Copy link
Contributor Author

ZeroDot1 commented Feb 8, 2025

Mm, I understand. However, I'd like them to have the same name to follow the already existing themes. Any other ideas?

@GyulyVGC It is okay to stick with the naming, but I would include a note in the documentation.
E.G.

OLED Themes for special displays and people with visual impairments.

OLED Theme Dark for people who need high contrast.
And for OLED displays to consume less power and protect the display.

OLED Theme Day For people with visual impairments who need less contrast but at the same time less bright colors.
OLED Day is particularly suitable for LED LCD and color E Ink displays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Styling and appearance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants