Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ukrainian translation for version 1.3. #692

Merged
merged 4 commits into from
Feb 1, 2025
Merged

Add Ukrainian translation for version 1.3. #692

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1619b5d
Add Ukrainian translation for version 3.
Kapelianovych Feb 1, 2025
7be26d3
Revisit existing Ukrainian translations.
Kapelianovych Feb 1, 2025
294f224
remove not anymore used character from subset
GyulyVGC Feb 1, 2025
9dd48ff
minor fix
GyulyVGC Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/translations/translations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,7 +990,7 @@ pub fn packets_chart_translation(language: Language) -> &'static str {
Language::ES => "paquetes por segundo",
Language::PL => "pakiety na sekundę",
Language::DE => "Pakete pro Sekunde",
Language::UK => "пакети(ів) на секунду",
Copy link
Contributor Author

@Kapelianovych Kapelianovych Feb 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GyulyVGC I personally wasn't able to check where this translation is used, but there is a special type of conjugation in Ukrainian language which depends on a preceding number. For example, if there is a 2 packets per second, it translates to 2 пакети на секунду, but 11 packets per second translates to 11 пакетів на секунду. Considering that I added parentheses with alternative ending. It might not be needed if there won't be such situation though.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I actually removed the (ів) from all the cases since I think it's fine to also use the singular. By the way that translation is used on the traffic chart heading when you switch to packets as data representation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Well, let it be like this for now. Maybe in future i18n feature can be improved to infer a context for a translation.

Language::UK => "пакети на секунду",
Language::ZH => "数据包",
Language::RO => "pachete pe secundă",
Language::KO => "초당 패킷",
Expand All @@ -1016,7 +1016,7 @@ pub fn bytes_translation(language: Language) -> &'static str {
Language::IT => "byte",
Language::FR => "octets",
Language::PL => "bajty",
Language::UK => "байти(ів)",
Language::UK => "байти",
Language::ZH => "网络流量",
Language::RO => "octeți",
Language::KO => "바이트",
Expand All @@ -1036,7 +1036,7 @@ pub fn bytes_chart_translation(language: Language) -> &'static str {
Language::ES | Language::PT => "bytes por segundo",
Language::PL => "bajty na sekundę",
Language::DE => "Bytes pro Sekunde",
Language::UK => "байти(ів) на секунду",
Language::UK => "байти на секунду",
Language::ZH => "网络流量",
Language::RO => "octeți pe secundă",
Language::KO => "초당 바이트",
Expand Down