Standardize process group_create_intrinsic(). (hpc#166)

Signed-off-by: Samuel K. Gutierrez <[email protected]>

src/qvi-group-process.cc

@@ -12,6 +12,7 @@
  */
 
 #include "qvi-group-process.h"
+#include "qvi-utils.h"
 
 int
 qvi_group_process_s::self(
@@ -35,6 +36,20 @@ qvi_group_process_s::self(
     return rc;
 }
 
+int
+qvi_group_process_new(
+    qvi_group_process_t **group
+) {
+    return qvi_new_rc(group);
+}
+
+void
+qvi_group_process_free(
+    qvi_group_process_t **group
+) {
+    qvi_delete(group);
+}
+
 /*
  * vim: ft=cpp ts=4 sts=4 sw=4 expandtab
  */

src/qvi-group-process.h

@@ -117,6 +117,16 @@ struct qvi_group_process_s : public qvi_group_s {
 };
 typedef qvi_group_process_s qvi_group_process_t;
 
+int
+qvi_group_process_new(
+    qvi_group_process_t **group
+);
+
+void
+qvi_group_process_free(
+    qvi_group_process_t **group
+);
+
 #endif
 
 /*

src/qvi-zgroup-process.cc

@@ -22,18 +22,19 @@ qvi_zgroup_process_s::group_create_intrinsic(
 ) {
     // NOTE: the provided scope doesn't affect how
     // we create the process group, so we ignore it.
-    qvi_group_process_t *igroup = new qvi_group_process_t();
+    qvi_group_process_t *igroup = nullptr;
+    int rc = qvi_group_process_new(&igroup);
+    if (rc != QV_SUCCESS) goto out;
 
-    int rc = igroup->initialize(zproc);
+    rc = igroup->initialize(zproc);
     if (rc != QV_SUCCESS) goto out;
 
     rc = qvi_process_group_create(
         zproc, &igroup->proc_group
     );
 out:
     if (rc != QV_SUCCESS) {
-        delete igroup;
-        igroup = nullptr;
+        qvi_group_process_free(&igroup);
     }
     *group = igroup;
     return rc;