Repository navigation
ci(release): write the resolver verdicts to GITHUB_OUTPUT - #117
Merged
Merged
Conversation
The #115 resolver built the output-writing command as a string but never executed it, so every publish step's if: saw an empty output and was skipped: the v4.3.2 release run resolved all five packages to publish and then published nothing (run 37897354034). The verdicts now append to GITHUB_OUTPUT directly. Verified against the live registry: all five 4.3.2 versions resolve to publish and the outputs land. Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #115 resolver built the output-writing command as a string but never executed it (
const flag = (pkg) =>echo ...``, thenflag(pkg)discards the return value). Every `Publish @guardcore/*` step's `if:` therefore saw an empty output and was skipped: the v4.3.2 release run (37897354034) resolved all five packages to publish and then published nothing. The verdicts now append to `GITHUB_OUTPUT` directly.Verified locally against the live registry: all five 4.3.2 versions resolve to publish and the outputs land.
Gates: turbo build 5/5, lint 5/5, test 10/10, test:coverage 10/10,
pnpm audit --audit-level=lowexit 0.no-issue