Issue #8 - unused temporary variables

GsDevKit · May 1, 2019 · 45e9cf7 · 45e9cf7
1 parent e1f2af4
commit 45e9cf7
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 12 deletions.
diff --git a/...DevKit_upgrade-Common.package/GsuAbstractGsDevKit.class/instance/_logUpgradeParameters.st b/...DevKit_upgrade-Common.package/GsuAbstractGsDevKit.class/instance/_logUpgradeParameters.st
@@ -1,8 +1,6 @@
 logging
 _logUpgradeParameters
 
-	| enabled |
-
 	self log: '	session methods ', (GsPackagePolicy enabled ifTrue: [ '(enabled)' ] ifFalse: [ '(disabled)' ]).
 	self _singletonUpgradeParameters do: [:selectorSymbol |
 		self log: '	', selectorSymbol asString, ' : ', (self perform: selectorSymbol) ].
@@ -11,4 +9,4 @@ _logUpgradeParameters
 		self log: '	', selectorSymbol asString, ' : '.
 		[ (self perform: selectorSymbol) 
 			do: [:entry | self log: '		', entry printString ] 
-		] on: Error do: [:ex  | self log: '			error extracting parameter ', ex description printString ] ]
+		] on: Error do: [:ex  | self log: '			error extracting parameter ', ex description printString ] ]
diff --git a/...uAbstractGsDevKitUpgrade.class/instance/prepareGsDevKitImage_existingConfigurationList.st b/...uAbstractGsDevKitUpgrade.class/instance/prepareGsDevKitImage_existingConfigurationList.st
@@ -4,7 +4,6 @@ prepareGsDevKitImage_existingConfigurationList
 	"Generate list of loaded configuration classes to be removed only the #_defaultExistingConfigurationOfNames need be removed,
 		since they will be used during loading of GLASS, GLASS1, GsDevKit, and tODE"
 
-	| requiredConfigurations |
 	self bootstrapExistingConfigurationList isEmpty ifFalse: [ "already set" ^ self ].
 	self log: '	create existing configuration list (commit)'.
 
@@ -17,4 +16,4 @@ prepareGsDevKitImage_existingConfigurationList
 								  self log: '		', className asString.
 								  self bootstrapExistingConfigurationList add: configurationOfClass ] ] ].
 	System commit.
-	self log: '	existing configuration collected (', self bootstrapExistingConfigurationList size asString, ')'.
+	self log: '	existing configuration collected (', self bootstrapExistingConfigurationList size asString, ')'.
diff --git a/gemstone/GsDevKit_upgrade.gs b/gemstone/GsDevKit_upgrade.gs
@@ -1443,8 +1443,6 @@ category: 'logging'
 method: GsuAbstractGsDevKit
 _logUpgradeParameters
 
-	| enabled |
-
 	self log: '	session methods ', (GsPackagePolicy enabled ifTrue: [ '(enabled)' ] ifFalse: [ '(disabled)' ]).
 	self _singletonUpgradeParameters do: [:selectorSymbol |
 		self log: '	', selectorSymbol asString, ' : ', (self perform: selectorSymbol) ].
@@ -1941,7 +1939,6 @@ prepareGsDevKitImage_existingConfigurationList
 	"Generate list of loaded configuration classes to be removed only the #_defaultExistingConfigurationOfNames need be removed,
 		since they will be used during loading of GLASS, GLASS1, GsDevKit, and tODE"
 
-	| requiredConfigurations |
 	self bootstrapExistingConfigurationList isEmpty ifFalse: [ "already set" ^ self ].
 	self log: '	create existing configuration list (commit)'.
 
@@ -2378,7 +2375,6 @@ prepareImage_user_bug46059
 
 	"until bug is fixed - should be run as SystemUser"
 
-	| package symbolDict class theSymbolList |
 	self log: '	patch MCGemStonePlatform >> removeClassFromSystem: (bug 46217)'.
 	GsPackageLibrary 
 		installMonticelloPackagesHome: (GsCurrentSession currentSession objectNamed: #'UserGlobals') 

diff --git a/rowan/src/GsDevKit_upgrade-Common/GsuAbstractGsDevKit.class.st b/rowan/src/GsDevKit_upgrade-Common/GsuAbstractGsDevKit.class.st
@@ -214,8 +214,6 @@ GsuAbstractGsDevKit >> _loadApplicationLoadSpecs: applicationLoadSpecs [
 { #category : 'logging' }
 GsuAbstractGsDevKit >> _logUpgradeParameters [
 
-	| enabled |
-
 	self log: '	session methods ', (GsPackagePolicy enabled ifTrue: [ '(enabled)' ] ifFalse: [ '(disabled)' ]).
 	self _singletonUpgradeParameters do: [:selectorSymbol |
 		self log: '	', selectorSymbol asString, ' : ', (self perform: selectorSymbol) ].

diff --git a/rowan/src/GsDevKit_upgrade-Core/GsuAbstractGsDevKitUpgrade.class.st b/rowan/src/GsDevKit_upgrade-Core/GsuAbstractGsDevKitUpgrade.class.st
@@ -533,7 +533,6 @@ GsuAbstractGsDevKitUpgrade >> prepareGsDevKitImage_existingConfigurationList [
 	"Generate list of loaded configuration classes to be removed only the #_defaultExistingConfigurationOfNames need be removed,
 		since they will be used during loading of GLASS, GLASS1, GsDevKit, and tODE"
 
-	| requiredConfigurations |
 	self bootstrapExistingConfigurationList isEmpty ifFalse: [ "already set" ^ self ].
 	self log: '	create existing configuration list (commit)'.