Avoid exit symbol in library #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main() function is expected to be a global function, the code won't link as a standalone executable if main() is put into a namespace. This fixes the following linking error: ----------------------------------------------------------------------- [ 32%] Linking CXX executable ../../../bin/test_sparse_array /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/Scrt1.o: in function `_start': (.text+0x20): undefined reference to `main' -----------------------------------------------------------------------
Split executable modules from the library object, in particular this is to prevent the exit() symbol to become part of the library, as this may raise some flags in linting tools like "lintian" from Debian, e.g.: X: libgrokj2k1: shlib-calls-exit usr/lib/x86_64-linux-gnu/libgrokj2k.so.7.1.0 Still keep executable sources grouped in a new GROK_EXECUTABLES_SRCS variable to be able to run cppcheck on all of them.
|
Thanks, Antonio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Aaron,
here are some misc build fixes, they started from a lintian issue but then I also noticed some other minor things when enabling options.
Ciao, Antonio