feat(flow): add eval interval option #6623
Open
+281
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
discord9
requested review from
zhongzc,
waynexia,
MichaelScofield,
evenyag and
a team
as code owners
github-actions
bot
added
size/M
docs-not-required
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
waynexia
reviewed
Jul 31, 2025
Comment on lines
+94
to
95
| CREATE FLOW calc_reqs SINK TO cnt_reqs EVAL INTERVAL '1m' AS | ||
| TQL EVAL (0, 15, '5s') count_values("status_code", http_requests); |
There was a problem hiding this comment.
About the grammar:
- we should check and warn/reject the absolute start/end (not express with
now()) - I don't prefer to add a new grammar section for this, and
- it's only for batching mode
- How about using
stepas the interval?
There was a problem hiding this comment.
About the grammar:
* we should check and warn/reject the absolute start/end (not express with `now()`) * I don't prefer to add a new grammar section for this, and * it's only for batching mode * How about using `step` as the interval?
step still sound too frequency, how about using end - start?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
add eval interval option, and add check that tql flow must have this option
PR Checklist
Please convert it to a draft if some of the following conditions are not met.