Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off by one in for Hatch Registration #2711

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

ghzdude
Copy link
Contributor

@ghzdude ghzdude commented Feb 3, 2025

What

fixes an off by one issue when registering hatches in MetaTileEntities introduced by #2497
which then causes a NPE when registering recipes for them

Implementation Details

+ 1

Outcome

we can dev again

@ghzdude ghzdude added type: bug Something isn't working ignore changelog PR should not be added to the changelog. labels Feb 3, 2025
@ghzdude ghzdude requested a review from a team as a code owner February 3, 2025 23:05
Copy link
Member

@Zorbatron Zorbatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbs up emoji

@Zorbatron Zorbatron added type: bug Something isn't working and removed type: bug Something isn't working labels Feb 3, 2025
@Zorbatron Zorbatron merged commit 68f6e52 into master Feb 3, 2025
5 checks passed
@Zorbatron Zorbatron deleted the gh/fix-off-by-one branch February 3, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore changelog PR should not be added to the changelog. type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants