Implement Bucket Behavior to Cells #2660
Conversation
move methods to IItemBehaviour
|
|
||
| blockHandler = createHandler(cellFluid, world, pos.offset(facing)); | ||
| success = GTTransferUtils.transferFluids(cellHandler, blockHandler) > 0; | ||
| isFill = true; |
There was a problem hiding this comment.
Are these isFill backwards? Right now you are setting isFill to true when you are attempting to transfer fluid from the cell into the world, which is emptying, not filling.
There was a problem hiding this comment.
i interpreted it as "filling the block", but it really could be either or.
src/main/java/gregtech/api/items/metaitem/stats/ItemFluidContainer.java
Outdated
Show resolved
Hide resolved
|
|
||
| var blockHandler = FluidUtil.getFluidHandler(world, result.getBlockPos().offset(result.sideHit), | ||
| result.sideHit); | ||
| int freeSpace = cellHandler.getTankProperties()[0].getCapacity() - (cellFluid == null ? 0 : cellFluid.amount); |
There was a problem hiding this comment.
This logic feels fragile to me-- if cellhandler.drain() fails to drain due to the handler saying no, but the handler contains fluid, that situation isn't accounted for.
There was a problem hiding this comment.
well, if we're unable to drain for some reason, then tryPlace() will return false and then we try to fill the held container. if both fail then nothing will happen
There was a problem hiding this comment.
Why does this earlier check exist then if it can fail with no repercussions?
There was a problem hiding this comment.
because the desired behavior is to pickup fluid if there's still space in the container, rather than prioritizing placing down the fluid.
now that i think about it, i think i could just flip tryPlace() and fillCell() and just use rayTrace(world, player, true), though there's still the edge case of placing fluid in other fluid.
There was a problem hiding this comment.
Do you want to do that, or just approve and merge?
There was a problem hiding this comment.
i'm gonna try to see if i can simplify things, don't merge yet
What
allows GT cells to pick up and place in world fluids
Implementation Details
add behavior to
ItemFluidContainerOutcome
"Finally, a weapon to surpass Thermal Expansion Reservoirs"