-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change IDataStickIntractable to use shift right clicking instead of left clicking. #2549
Open
Zorbatron
wants to merge
12
commits into
GregTechCEu:master
Choose a base branch
from
Zorbatron:zb-better-copying
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALongStringOfNumbers
approved these changes
Aug 8, 2024
I'm removing the "allow copying the settings of singleblock machines" part of this PR as I plan to make a specific tool for it. |
Zorbatron
changed the title
Make the copying of ME input parts better and allow copying the settings of singleblock machines.
Change IDataStickIntractable to use shift right clicking instead of left clicking.
Sep 1, 2024
# Conflicts: # src/main/java/gregtech/api/metatileentity/MetaTileEntity.java # src/main/java/gregtech/common/metatileentities/multi/multiblockpart/appeng/MetaTileEntityMEInputBus.java # src/main/java/gregtech/common/metatileentities/multi/multiblockpart/appeng/MetaTileEntityMEInputHatch.java # src/main/resources/assets/gregtech/lang/en_us.lang # src/main/resources/assets/gregtech/lang/ru_ru.lang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes the action of data sticks to be shift right clicking instead of left clicking.
Also resolves #2464.
Implementation Details
Changes
onDataStickLeftClick
toonDataStickShiftRightClick
inIDataStickIntractable
I moved some lang around to match en_us, but the other languages will still say left click to copy.
Potential Compatibility Issues
Any addon that uses
IDataStickIntractable