MUI for multiblock I/O buses #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
reviewed
Dec 8, 2023
src/main/java/gregtech/api/mui/synchandler/GhostCircuitSyncHandler.java
Outdated
Show resolved
Hide resolved
brachy84
reviewed
Dec 8, 2023
src/main/java/gregtech/api/mui/widget/GhostCircuitSlotWidget.java
Outdated
Show resolved
Hide resolved
ghzdude
reviewed
Dec 8, 2023
src/main/java/gregtech/common/metatileentities/multi/multiblockpart/MetaTileEntityItemBus.java
Outdated
Show resolved
Hide resolved
TechLord22
reviewed
Dec 10, 2023
src/main/java/gregtech/api/mui/synchandler/GhostCircuitSyncHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/mui/synchandler/GhostCircuitSyncHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/mui/widget/GhostCircuitSlotWidget.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/metatileentities/multi/multiblockpart/MetaTileEntityItemBus.java
Show resolved
Hide resolved
...n/java/gregtech/common/metatileentities/steam/multiblockpart/MetaTileEntitySteamItemBus.java
Show resolved
Hide resolved
There was a problem hiding this comment.
The Buses (currently) must be connected to a multiblock for auto-collapse to work. This should be reflected in the auto-collapse button. Something like Greyed out when not connected, with a tooltip explaining.
I noticed that the steam buses do not have the additional buttons, although they can still be disabled and set to auto-collapse. Is this just the usual of steam stuff not having advanced UIs, or was this an oversight?
TechLord22
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also implements the new Ghost Circuit widget in MUI2, now with the circuit selector pop-up