Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable module configuration file #2147

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Re-enable module configuration file #2147

merged 3 commits into from
Nov 10, 2023

Conversation

serenibyss
Copy link
Member

Enables the gregtech/modules.cfg configuration file for enabling/disabling individual modules. Re-enabling this now since integration module development has picked up again

@serenibyss serenibyss added the type: refactor Suggestion to refactor a section of code label Nov 5, 2023
@serenibyss serenibyss requested a review from a team as a code owner November 5, 2023 00:54
ALongStringOfNumbers
ALongStringOfNumbers reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@ALongStringOfNumbers ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module descriptions in modules.cfg are not localized, but everything else looks good.

ALongStringOfNumbers
ALongStringOfNumbers approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@ALongStringOfNumbers ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we put a big warning at the top of the changelog for people to copy their config over into the gregtech folder

@TechLord22 TechLord22 merged commit e621cdd into master Nov 10, 2023
3 checks passed
@TechLord22 TechLord22 deleted the sb-reenable-module-config branch November 10, 2023 02:24
ALongStringOfNumbers pushed a commit that referenced this pull request Nov 10, 2023
@serenibyss @TechLord22 @ALongStringOfNumbers
Re-enable module configuration file (#2147)
08c7f57 
Co-authored-by: TechLord22 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ALongStringOfNumbers ALongStringOfNumbers ALongStringOfNumbers approved these changes

Assignees
No one assigned
Labels
type: refactor Suggestion to refactor a section of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serenibyss @ALongStringOfNumbers @TechLord22