Refactor Cover/Machine attachment interaction #3458
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttachment interaction occurs
YoungOnionMC
added
type: refactor
… into yo/cover-attachment # Conflicts: # src/main/java/com/gregtechceu/gtceu/common/data/models/GTMachineModels.java
jurrejelle
reviewed
Jul 17, 2025
Contributor
jurrejelle
left a comment
jurrejelle
left a comment
There was a problem hiding this comment.
Now we lose KubeJS functionality to define these; if someone wants a singleblock that can attach io covers to front they will have to make a coremod and make a class that overrides metamachine for their blocks. Is that something we care about?
Ghostipedia
added
the
Release: Major - 0.X.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
removes the opt in front facing cover placement field instead using a method if we need the machine state as well
cleans up the folder structure of all the covers
Outcome
determining which covers can attach to what machine should be easier to understand
you can place non io covers on singleblocks now
fixes #3455