Fix prospecting inconsistencies #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the bug that made the prospector register ore veins when scanning for fluids.
Adds the ability for the portable scanner to register bedrock fluids in the scanned chunk.
Adds/refactors all packets used for syncing the various vein types.
Implementation Details
The packets for syncing veins are composed of a table containing
(ResourceKey<Level>, BlockPos, T)whereTis the vein type.Outcome
Fixes #2672
Potential Compatibility Issues
The packet previously used to sync ore veins was deleted in favor of the new approach.