-
Notifications
You must be signed in to change notification settings - Fork 57
add glowing texture for everything that should glow #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hrrrm, i did not think of glowing textures at all when i made this stuff, definitely need to find a good way to properly implement it with texturepack support and such, instead of merely changing some hardcoded values. |
hmm, maybe we can just make every machine have useGlowingTexture= true, and just put completely transparent texture to machines that not glow. this may makes texture pack easier... but doing so makes resources dir very large another method is make a meta file alongside png file, describing if texture should glow and its brightness, but I have no idea about code and how to implement it.. |
That would be about 160 or so Kilobytes if I do it the "just have a transparent glowing textures layer" way. Empty Textures do not have much of a File Size. |
(cherry picked from commit ded9d35)
just make things glow.
those codes are cherry-picked from my own repo that changes a lot to make my modpack. Though I carefully removed that sort of things, I don't sure if that really not contains recipes changes or something...remove them if you find them.
And also feel free to change naming or something.
and here is a image to show the final effect. (not every changed machine is on those image)
using BSL shader with angelica
and without the shader