Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #1

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Dev #1

wants to merge 14 commits into from

Conversation

FireInstall
Copy link
Collaborator

The newish Materials where missing again, and I was annoyed.

Fixed surrounding quotation marks of messages
Removed unused "defaultMessages"
@FireInstall FireInstall force-pushed the dev branch 2 times, most recently from f4f78f8 to 9452bab Compare March 27, 2024 06:07
@FireInstall
Copy link
Collaborator Author

RifleChairs: Fixes

paper plugin
1.21
@seema84
Copy link

seema84 commented Dec 19, 2024

Can you perhaps also fix the incorrect seat height on slap? The adjustments in the config have no effect (only for slaps).
Is perhaps only "g" which is too much for slab-seating-position"g": 0.5,0.3,0.5

@FireInstall
Copy link
Collaborator Author

You are completely correct, good catch, thanks!
I have a fix locally, will push as soon as I can verify against our config

update dependencies
update minecraft to the latest stable paper build (1.21.4 does not work currently, probably do to the hard fork restructure)
fix config key "slab-seating-position" having a tailing "g", thanks @seema84
moved the default values up, as the old ones looked wrong and resulted in glitching through blocks in case of carpets (some minecraft update changed the point of seating on armor stands down)
removed helper method to check if a Material is air, as Material already has a method for this.
…hout having to download it manually.

Removed wrong comment
@seema84
Copy link

seema84 commented Dec 20, 2024

You are completely correct, good catch, thanks! I have a fix locally, will push as soon as I can verify against our config

thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants