Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0 #1

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Version 2.0 #1

wants to merge 8 commits into from

Conversation

FireInstall
Copy link
Collaborator

@FireInstall FireInstall commented Jul 25, 2024

  • builds on top of addstars (Narimm) 1.0 version
  • Refactor code to clean up!

@FireInstall
Copy link
Collaborator Author

FireInstall commented Jul 25, 2024

@addstar I hope it's ok that I used the jar file on your maven to copy the api-key and deletion code.
I'm happy to open a PR on your Repo as well, if you make it public.

(until we have an awnser this should not get merged!)

@FireInstall FireInstall marked this pull request as draft July 25, 2024 06:54
@addstar
Copy link

addstar commented Jul 25, 2024

@addstar I hope it's ok that I used the jar file on your maven to copy the api-key and deletion code.

Heya @FireInstall 👋 I don't even remember what this is for or which key you mean?

I'm happy to open a PR on your Repo as well, if you make it public.

Which repo do you want made public? We're happy for you to contribute to any of our stuff 🙂 you make a lot of great changes!

@FireInstall
Copy link
Collaborator Author

FireInstall commented Jul 29, 2024

@addstar
This is the paste.gg api made by Matt Baxter, who made https://kitteh.org (dead now)
The Minigames Plugin depends on it, since the debug commands collects much data and posts it on paste.gg - a paste bin. You can add your files anonymously and it works fine.
But Minigames uses a feature the original public code doesn't include: the use of api - keys for paste.gg. It helps to keep track of pastes past the next server restart.
Narimm contributed in the past to the project and the specific .jar Minigames uses stems from your maven.

Well, seems like I didn't look close enough. GitHub didn't show me the list of forks of the original repo, so I assumed it's a private one of your organisation.
However, seems like Narimm just created it under his account. Maybe he did upload it to your maven manually? I don't know.
Minigames doesn't really profit from most of my work here - but it should receive dependency upgrades at least, since Minigames did run far too long with a security issue based on a Gson attack.

tl;dr: Since you inherited Narimms legacy:

  1. Do you approve of the usage of his code here? (should be all under MIT license anyway)
  2. We need a new home for the code and a maven repo. Do you want to keep it all under your umbrella and set everything up (if missing) and I open a PR there or do you want us to host it in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants