Feuer fixes #30
Merged
Feuer fixes #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dokumentation renamed blockRecorder package to just recorder to reflect that entities get recorded as well. Also, it makes codacy happy.
Fix Volume calculation of regen regions being one block of in each axis
I have one question: why?
fix waxed signs not receiving an update
… ended and not only if the GameEndPhase was reached.
…sn't properly started yet)
…ting the message in the chat
… null * Teleports the spectating players to the end location if a quit location is not set. Fixes Spectators getting stuck in Minigame if no endpostion was set.
fix air test for treasures fix hardcoded number of inventory slots for treasures (allowing other containers getting used in future if someone decides to make this part configurable)
added description, so the plugin doesn't crash in case the outputCMDToFile was turned on
In rare occasions a user can be a spectator as well as a player (however that happened)
This may still have a desync problem with the client where menu items are invisible. This, however is a client problem and even player.updateInventory will not help, as it get called anyway if the event gets cancelled.
joshi1999
reviewed
Feb 23, 2024
Regions/src/main/java/au/com/mineauz/minigamesregions/conditions/BlockOnAndHeldCondition.java
Outdated
Show resolved
Hide resolved
Minigames/src/main/java/au/com/mineauz/minigames/signs/SignBase.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopen of #23 - I have renamed the branch since I have multible dev banches open
dokumentation
Added GreenSurvivors as authors
renamed blockRecorder package to just recorder to reflect that entities get recorded as well. Also, it makes codacy happy.
some minor fixes
added GameEnded trigger that allways fires if a game has come to an end (not only if it is in its endphase)