Adding recorder deactivation option #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schpammer
approved these changes
Dec 15, 2023
|
rebased onto dev |
FireInstall
requested changes
Jan 11, 2024
Minigames/src/main/java/au/com/mineauz/minigames/blockRecorder/RecorderData.java
Outdated
Show resolved
Hide resolved
Regions/src/main/java/au/com/mineauz/minigamesregions/conditions/MatchTeamCondition.java
Show resolved
Hide resolved
FireInstall
force-pushed
the
devjoshi
branch
from
d8b8474 to
9e70022
Compare
RegenRecorder etc. are working now just fine
FireInstall
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
Nice one! Thanks!
(one teeny tiny bit of nitpick thou, since you include - rightfully - entities could you rename ActivateBlockRecorder to something like ActivatePlayerRecorder or something? We could stay backwards compatible in config, even if it really doesn't matter for one single Minigame but for self dokumenting code it would be nice)
|
I just couldn't decide whether to rename it or not, but the self documentating code is probably the best argument ^^ |
|
Perfection. Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To accomplish a minigame, which you only use once (or only one day) and the building and mining progress is valuable after the game.